mihaibudiu commented on code in PR #3754:
URL: https://github.com/apache/calcite/pull/3754#discussion_r1556464056
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2162,6 +2162,48 @@ private SqlDialect nonOrdinalDialect() {
.ok(prestoExpected);
}
+ /**
+ * Test case for the base case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6355">[CALCITE-6355]
Review Comment:
So far we have required the JIRA case title, the PR case title, and the
comments in the code to use the exact same text.
This makes it easy to understand how these are related.
Can you please follow these guidelines?
There are lots of examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]