mihaibudiu commented on code in PR #3754:
URL: https://github.com/apache/calcite/pull/3754#discussion_r1558147024
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -2162,6 +2162,48 @@ private SqlDialect nonOrdinalDialect() {
.ok(prestoExpected);
}
+ /**
+ * Test case for the base case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6355";>[CALCITE-6355]
Review Comment:
Eventually after the PR is accepted you will have to squash all the commits
to just one, and that one will have to have the exact same message as the JIRA
title, and this PR title. Moreover, the JavaDoc for the test cases related to
the fix also have to have a relatively rigid format, providing the link to the
jira case and the full text in the jira title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
