frostruan commented on code in PR #3760:
URL: https://github.com/apache/calcite/pull/3760#discussion_r1569909057


##########
core/src/main/java/org/apache/calcite/rex/RexUtil.java:
##########
@@ -3191,4 +3231,75 @@ private static class SearchExpandingShuttle extends 
RexShuttle {
       }
     }
   }
+
+  /**
+   * Reorders some of the operands in this expression so structural comparison.
+   *
+   * <p>This is mostly the same as {@link SubstitutionVisitor#canonizeNode}, 
except
+   * that comparator is based on the {@link SqlKind}'s ordinal rather than 
string
+   * representation lexicographic order, which allows constant to always be on 
the
+   * right side of the expression. See {@link RexNormalize#reorderOperands} 
for details.
+   */
+  public static RexNode canonizeNode(RexBuilder rexBuilder, RexNode 
expression) {

Review Comment:
   Ok. I'll fix this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to