Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571070432
##########
core/src/test/resources/sql/cast-with-format.iq:
##########
@@ -979,7 +939,7 @@ EXPR$0
select cast(date'2019-01-07' as varchar
FORMAT 'WW');
EXPR$0
-01
+02
Review Comment:
Agreed, a small number of the tests return the same answer as recorded here
as they produced the same week number irrespective of start of week, the others
had to be changed wrt to what Calcite/BQ is returning.
Another point to consider with these tests is BQ does not support use of
elements like `WW`, `DDD` to parse a datetime object, its only available for
formatting output strings. I left these tests as is because we do not have any
restrictions in calcite's `FormatModel` for the use of elements in parsing or
formatting scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
