mihaibudiu commented on code in PR #3762:
URL: https://github.com/apache/calcite/pull/3762#discussion_r1575303020


##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -2006,7 +2006,7 @@ void checkPeriodPredicate(Checker checker) {
     expr("1-2+3*4/5/6-7")
         .ok("(((1 - 2) + (((3 * 4) / 5) / 6)) - 7)");
     expr("power(2,3)")
-        .ok("POWER(2, 3)");
+        .ok("`POWER`(2, 3)");

Review Comment:
   I don't know the answer to this question. But I know that Calcite can load 
multiple libraries, and I believe a function will be resolved by trying the 
libraries in order. I also am assuming that there is nothing special about the 
standard operator table. So if you load the postgres operator table first, 
perhaps the right POWER will be used?
   
   A quick experiment should be able answer this question.
   
   If this works, we should probably document that the right way to implement a 
dialect is to load the dialect specific operator table first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to