mihaibudiu commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1575417379
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -598,6 +598,13 @@ void testCastBooleanToNumeric(CastType castType,
SqlOperatorFixture f) {
"Cast function cannot convert value of type BOOLEAN to type
DECIMAL\\(19, 0\\)", false);
}
+ /** Test case for <a
href="https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6322";>
+ * [CALCITE-6322] Casts to DECIMAL types are ignored</a>. */
Review Comment:
I will re-enable many of these tests, but this doesn't completely solve the
cases covered by SqlOperatorTest.DECIMAL. I have filed a new issue
https://issues.apache.org/jira/browse/CALCITE-6379 that covers arithmetic.
Moreover, the current PR also does not cover casts from STRING and INTERVAL. I
have filed https://issues.apache.org/jira/browse/CALCITE-6380 to cover these
two cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
