mihaibudiu commented on code in PR #3721:
URL: https://github.com/apache/calcite/pull/3721#discussion_r1580018917
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1163,6 +1163,52 @@ private static RelDataType
mapReturnType(SqlOperatorBinding opBinding) {
false);
}
+ @SuppressWarnings("argument.type.incompatible")
+ private static RelDataType mapKeyReturnType(SqlOperatorBinding opBinding) {
+ List<RelDataType> operandType = new ArrayList<>();
+
+ operandType.add(opBinding.collectOperandTypes().get(0).getKeyType());
+ operandType.add(opBinding.collectOperandTypes().get(0).getValueType());
+ Pair<@Nullable RelDataType, @Nullable RelDataType> type =
+ getComponentTypes(
+ opBinding.getTypeFactory(), operandType);
+
+ requireNonNull(type.left, () -> "type left of " + type.left);
+ requireNonNull(type.right, () -> "type right of " + type.right);
+ if (type.left.getSqlTypeName() != SqlTypeName.UNKNOWN
+ && type.right.getSqlTypeName() != SqlTypeName.UNKNOWN) {
+ SqlValidatorUtil.adjustTypeForMapFunctionConstructor(type, opBinding);
Review Comment:
I am asking whether the returnTypeInference function is allowed to change
the opBinding.
Did you see other examples in the code where this happens?
Neither map_concat or map_entries do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
