mihaibudiu commented on PR #3771: URL: https://github.com/apache/calcite/pull/3771#issuecomment-2079863779
I am relatively new to Calcite myself, and I wasn't a contributor when JSON_QUERY was introduced. So I search for tests probably in the same way you do, using file search. I am not asking to test exhaustively JSON_QUERY in this PR, that would be a daunting effort, and maybe there aren't enough tests in Calcite. I just want to make sure that there are tests for the new feature that is implemented. I have noticed that many times the negative tests uncover bugs, so I think it's very useful to have a few of them as well. If gradlew fails on a clean checkout maybe you should file an issue or quiz the dev mailing list. I think you should add the comments above about issue [CALCITE-6208](https://issues.apache.org/jira/browse/CALCITE-6208) to the issue itself in JIRA. If that helps close the issue, great. I think the community prefers to have design decisions in the JIRA issues. But note that Calcite supports many SQL dialects, and sometimes offers additional functionality if it is reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
