normanj-bitquill commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2088777985

   @mihaibudiu 
   > This is pretty close, the existing file 
`core/src/test/resources/sql/sub-query.iq` already uses the postgres format. 
What I would do is to make a small python script to convert the postgres output 
into a .iq file, which you can hopefully just add to the resources directory in 
java. Then, before you commit, make sure the tests in the file are being 
executed by introducing a typo. And please add a comment to the iq file stating 
the Postgres version that was used to generate it. I am not sure whether there 
is some place where the python script itself could be committed...
   
   Added the queries here:
   
https://github.com/Bit-Quill/calcite/blob/calcite-6358/core/src/test/resources/pg_to_char_queries.sql
   
   Here is a script that is able to generate the *.iq file:
   
https://github.com/Bit-Quill/calcite/blob/calcite-6358/core/src/test/resources/to_char_generate_iq.py
   
   Ran the `:core:test` target with the generated *.iq file. Verified that the 
file is run by adding an error. The generated file is executed successfully 
with no errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to