jduo commented on PR #3757: URL: https://github.com/apache/calcite/pull/3757#issuecomment-2103386557
> @jduo, I have made some modifications to the PR in [this commit](https://github.com/asolimando/calcite/commit/27b5d879b8097bac8be5b53b27d776407e312094), can you take a look? > > I have added a conditional check on the results based on the status of the ticket you filed (as it's customary in Calcite), and I have also refined some tests and added few more > > EDIT: finally it seems that all traits are dropped by this bug, so I suggest to rename the jira ticket as "[[CALCITE-6340](https://issues.apache.org/jira/browse/CALCITE-6340)] RelBuilder drops traits when aggregating over duplicate projected fields" and update it in the final commit (when you will be squashing after getting approval) and wherever it is referenced in the code I think the changes proposed are mostly OK, but the Bug entry should be for the new ticket (6391) instead of this one (6340). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
