caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597579339
##########
site/_docs/reference.md:
##########
@@ -2812,6 +2812,7 @@ In the following:
| b m p s | MD5(string) | Calculates an MD5
128-bit checksum of *string* and returns it as a hex string
| m | MONTHNAME(date) | Returns the name, in
the connection's locale, of the month in *datetime*; for example, it returns
'二月' for both DATE '2020-02-10' and TIMESTAMP '2020-02-10 10:10:10'
| o s | NVL(value1, value2) | Returns *value1* if
*value1* is not null, otherwise *value2*
+| s | NVL2(value1, value2, value3) | Returns *value2* if
*value1* is not null, or *value3* otherwise.
Review Comment:
fix
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -10397,6 +10397,50 @@ void assertSubFunReturns(boolean binary, String s, int
start,
checkNvl(f, FunctionAlias.of(SqlLibraryOperators.NVL));
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6397";>[CALCITE-6397]
+ * Add NVL2 function (enabled in Spark library). </a>.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
