caicancai commented on code in PR #3789:
URL: https://github.com/apache/calcite/pull/3789#discussion_r1612579694
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -645,12 +646,14 @@ Builder populate() {
defineMethod(EXP, BuiltInMethod.EXP.method, NullPolicy.STRICT);
defineMethod(POWER, BuiltInMethod.POWER.method, NullPolicy.STRICT);
defineMethod(ABS, BuiltInMethod.ABS.method, NullPolicy.STRICT);
- defineMethod(LOG2, BuiltInMethod.LOG2.method, NullPolicy.STRICT);
map.put(LN, new LogImplementor());
map.put(LOG, new LogImplementor());
map.put(LOG10, new LogImplementor());
+ map.put(LOG_MYSQLSPARK, new LogMysqlSparkImplementor());
Review Comment:
@normanj-bitquill Yes, you are right, so I use the name LOGMYSQLSPARK. The
method you mentioned is something I didn't expect. Let me try it.
Thank you for your reply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
