NobiGo commented on code in PR #3798:
URL: https://github.com/apache/calcite/pull/3798#discussion_r1615531463
##########
core/src/main/java/org/apache/calcite/util/RelToSqlConverterUtil.java:
##########
@@ -63,6 +63,36 @@ public static void unparseHiveTrim(
}
}
+ /**
+ * Unparses Array and Map value constructor.
+ *
+ * <p>For example :
+ *
+ * <blockquote><pre>
+ * SELECT ARRAY[1, 2, 3] → SELECT ARRAY (1, 2, 3)
+ * SELECT MAP['k1', 'v1', 'k2', 'v2'] → SELECT MAP ('k1', 'v1', 'k2',
'v2')
+ * </pre></blockquote>
+ *
+ * @param writer writer
+ * @param call the call
+ */
+ public static void unparseSparkArrayAndMap(SqlWriter writer,
Review Comment:
Hi @YiwenWu ,I noticed this too. So how about when we merge this after , In
another PR ,We can create new SqlNodeToSqlUtil , Then refactor the relative
code ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
