Re: [PR] [CALCITE-6422] RexLiteral.isNullLiteral should be applied before RexLiteral.booleanValue in SubstitutionVisitor.mayBeSatisfiable [calcite]

Tue, 28 May 2024 19:47:35 -0700 


l4wei commented on code in PR #3800:
URL: https://github.com/apache/calcite/pull/3800#discussion_r1618110308


##########
core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java:
##########
@@ -443,7 +443,8 @@ public static boolean mayBeSatisfiable(RexNode e) {
     for (RexNode disjunction : disjunctions) {
       switch (disjunction.getKind()) {
       case LITERAL:
-        if (!RexLiteral.booleanValue(disjunction)) {
+        if (!RexLiteral.isNullLiteral(disjunction)

Review Comment:
   I see, the null value is generated by following method:
   
![20240529104501](https://github.com/apache/calcite/assets/20348640/975589d5-a3fe-4dcc-b52a-2dd2a3c32d5d)
   And the nullAs is UNKNOWN in materialized view matching.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to