YiwenWu commented on code in PR #3812:
URL: https://github.com/apache/calcite/pull/3812#discussion_r1628635561
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -14575,6 +14611,42 @@ private static void checkBoolOrFunc(SqlOperatorFixture
f) {
f.checkAgg("bool_or(x)", values4, isNullValue());
}
+ @Test void testBoolOrAggfunc() {
Review Comment:
same as above
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -14527,6 +14527,42 @@ private static void
checkBoolAndFunc(SqlOperatorFixture f) {
f.checkAgg("bool_and(x)", values4, isNullValue());
}
+ @Test void testBoolAndAggFunc() {
Review Comment:
suggestion: can be merged with `SqlOperatorTest#testBoolAndFunc` to verify
the same underlying Function implementation.
Please refer to `SqlOperatorTest#testRlikeOperator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
