normanj-bitquill commented on code in PR #3828:
URL: https://github.com/apache/calcite/pull/3828#discussion_r1664561471
##########
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##########
@@ -1900,6 +1902,60 @@ private static class GreatestConvertlet implements
SqlRexConvertlet {
}
}
+ /** Convertlet that converts {@code GREATEST} and {@code LEAST}. */
+ private static class GreatestPgConvertlet implements SqlRexConvertlet {
+ @Override public RexNode convertCall(SqlRexContext cx, SqlCall call) {
Review Comment:
You are right. Let expressions would avoid repeated evaluation of the
arguments. Does Calcite support LET expressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
