soumyakanti3578 commented on code in PR #3849:
URL: https://github.com/apache/calcite/pull/3849#discussion_r1669218319
##########
core/src/test/java/org/apache/calcite/test/RelBuilderTest.java:
##########
@@ -2650,19 +2650,17 @@ private static RelBuilder assertSize(RelBuilder b,
b.scan("EMP")
.scan("DEPT")
.join(JoinRelType.INNER,
- b.or(b.literal(null),
- b.and(b.equals(b.field(2, 0, "DEPTNO"), b.literal(1)),
- b.equals(b.field(2, 0, "DEPTNO"), b.literal(2)),
- b.equals(b.field(2, 1, "DEPTNO"),
- b.field(2, 0, "DEPTNO")))))
+ b.and(b.equals(b.field(2, 0, "DEPTNO"), b.literal(1)),
Review Comment:
Keeping a NULL literal makes the type of the condition to be of type NULL.
This PR is not ready for review, and I am just testing things as tests are
failing on my local machine with unrelated errors. I will mark this PR as draft
for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
