rubenada commented on code in PR #3850:
URL: https://github.com/apache/calcite/pull/3850#discussion_r1670587166
##########
core/src/main/java/org/apache/calcite/rel/rules/SortRemoveConstantKeysRule.java:
##########
@@ -77,8 +78,13 @@ protected SortRemoveConstantKeysRule(Config config) {
return;
}
+ final RelCollation collation =
+
RelCollationTraitDef.INSTANCE.canonize(RelCollations.of(collationsList));
final Sort result =
- sort.copy(sort.getTraitSet(), input, RelCollations.of(collationsList));
+ sort.copy(
Review Comment:
`RelOptRulesTest#testSortRemovalOneKeyConstant` with the proposed adjustment
tests this (otherwise the adjusted test fails). I have described it a bit more
in detail on the Jira ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
