mihaibudiu commented on code in PR #3851:
URL: https://github.com/apache/calcite/pull/3851#discussion_r1672601660
##########
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java:
##########
@@ -982,11 +982,17 @@ void propagateCostImprovements(RelNode rel) {
if (!relNode.getTraitSet().satisfies(subset.getTraitSet())) {
continue;
}
- if (!cost.isLt(subset.bestCost)) {
+
+ // Update subset best and best's cost when we find a cheaper rel
Review Comment:
these two comments do not really seem to describe what the code next to them
is doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
