normanj-bitquill commented on code in PR #3833:
URL: https://github.com/apache/calcite/pull/3833#discussion_r1672993632
##########
core/src/main/java/org/apache/calcite/util/format/postgresql/FormatPattern.java:
##########
@@ -36,6 +59,152 @@ public interface FormatPattern {
* @param dateTime datetime to convert
* @return the string representation of the datetime based on the format
pattern
*/
- @Nullable String convert(ParsePosition parsePosition, String formatString,
+ public abstract @Nullable String convert(ParsePosition parsePosition, String
formatString,
ZonedDateTime dateTime);
+
+ /**
+ * Get the ChronoUnitEnum value that this format pattern represents. For
example, the
+ * pattern YYYY is for YEAR.
+ *
+ * @return a ChronoUnitEnum value
+ */
+ protected abstract ChronoUnitEnum getChronoUnit();
+
+ /**
+ * Attempts to parse a single value from the input for this pattern. It will
start parsing
Review Comment:
@mihaibudiu I see what you mean now. I have updated the return type and
updated any tests that were affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
