normanj-bitquill commented on PR #3852: URL: https://github.com/apache/calcite/pull/3852#issuecomment-2226448971
> @normanj-bitquill > > 1. I find different data source has different behaviour about NULL value: > > ``` > spark-sql (default)> select array(1,2)>array(1,null); > true > Time taken: 0.192 seconds, Fetched 1 row(s) > spark-sql (default)> select array(1,2)<array(1,null); > false > Time taken: 0.127 seconds, Fetched 1 row(s) > ``` > > But this maybe another issue to resolve it. > > 2. Please add the code annotation before the test to clarify the test. Other good to me. 1. I don't see any obvious way to support specifying the null order. It might help to consider how it should be configured. When building a Spark engine using Calcite, what would the ideal way of specifying whether NULLs should be first or last in array comparisons? 2. I'm not sure what you mean. I added a comment before the tests to say what they are for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
