caicancai commented on code in PR #3847:
URL: https://github.com/apache/calcite/pull/3847#discussion_r1676829343
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -8182,6 +8182,19 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functionAlias) {
"CHAR(3) NOT NULL ARRAY NOT NULL");
f1.checkScalar("map_keys(map('foo', 1, null, 2))", "[foo, null]",
"CHAR(3) ARRAY NOT NULL");
+
+ f1.checkScalar("map_keys(map('foo', 1, null, 2))", "[foo, null]",
Review Comment:
done, I tested all versions after spark3.4
##########
core/src/main/java/org/apache/calcite/sql/type/NonNullableAccessors.java:
##########
@@ -58,4 +58,10 @@ public static RelDataType getKeyTypeOrThrow(RelDataType
type) {
return requireNonNull(type.getKeyType(),
() -> "keyType is null for " + type);
}
+
+ @API(since = "1.37", status = API.Status.EXPERIMENTAL)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
