caicancai commented on code in PR #3839:
URL: https://github.com/apache/calcite/pull/3839#discussion_r1676992591
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -2788,38 +2788,50 @@ public static double power(BigDecimal b0, BigDecimal
b1) {
// LN, LOG, LOG10, LOG2
- /** SQL {@code LOG(number, number2)} function applied to double values. */
- public static @Nullable Double log(double number, double number2, int
nullFlag) {
- if (nullFlag == 1 && number <= 0) {
+ /** SQL {@code LOG(number, base)} function applied to double values. */
Review Comment:
I'm worried that this makes the code redundant, so I thought I could add a
comment to make this clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
