This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 95fedabe27 [CALCITE-6466] Add benchmark for SQL parser instantiation
95fedabe27 is described below
commit 95fedabe27b655a498fcdfea9967565dd4776336
Author: Cyril de Catheu <[email protected]>
AuthorDate: Thu Jul 11 09:51:13 2024 +0200
[CALCITE-6466] Add benchmark for SQL parser instantiation
Close apache/calcite#3853
---
ubenchmark/README.md | 2 +-
ubenchmark/build.gradle.kts | 1 +
.../benchmarks/ParserInstantiationBenchmark.java | 100 +++++++++++++++++++++
3 files changed, 102 insertions(+), 1 deletion(-)
diff --git a/ubenchmark/README.md b/ubenchmark/README.md
index 17b1163108..17e8ef3742 100644
--- a/ubenchmark/README.md
+++ b/ubenchmark/README.md
@@ -38,7 +38,7 @@ following task:
```kotlin
jmh {
- include = listOf("removeAllVertices.*Benchmark")
+ includes = listOf("removeAllVertices.*Benchmark")
}
```
diff --git a/ubenchmark/build.gradle.kts b/ubenchmark/build.gradle.kts
index 1764da53f5..7d131ad8e6 100644
--- a/ubenchmark/build.gradle.kts
+++ b/ubenchmark/build.gradle.kts
@@ -20,6 +20,7 @@ plugins {
dependencies {
jmhImplementation(platform(project(":bom")))
+ jmhImplementation(project(":babel"))
jmhImplementation(project(":core"))
jmhImplementation(project(":linq4j"))
jmhImplementation("com.google.guava:guava")
diff --git
a/ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java
b/ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java
new file mode 100644
index 0000000000..bb804bbf9f
--- /dev/null
+++
b/ubenchmark/src/jmh/java/org/apache/calcite/benchmarks/ParserInstantiationBenchmark.java
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.benchmarks;
+
+import org.apache.calcite.sql.parser.SqlParser;
+import org.apache.calcite.sql.parser.babel.SqlBabelParserImpl;
+
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Param;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Threads;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.runner.Runner;
+import org.openjdk.jmh.runner.RunnerException;
+import org.openjdk.jmh.runner.options.Options;
+import org.openjdk.jmh.runner.options.OptionsBuilder;
+
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Benchmarks JavaCC-generated SqlBabelParserImpl and ImmutableSqlParser
instantiation.
+ * The instantiation time of parsers should not depend on the call stack depth.
+ * See https://lists.apache.org/thread/xw35sdy1w1k8lvn1q1lr7xb93bkj0lpq
+ */
+@Fork(value = 1, jvmArgsPrepend = "-Xmx128m")
+@Measurement(iterations = 7, time = 1, timeUnit = TimeUnit.SECONDS)
+@Warmup(iterations = 7, time = 1, timeUnit = TimeUnit.SECONDS)
+@State(Scope.Thread)
+@Threads(1)
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.MICROSECONDS)
+public class ParserInstantiationBenchmark {
+
+ @Param({"0", "100"})
+ int stackDepth;
+
+ @Param({"core", "babel"})
+ String parser;
+
+ SqlParser.Config config;
+ String sqlExpression;
+
+ @Setup
+ public void setup() {
+ // not important in this benchmark, see ParserBenchmark for varying string
length
+ sqlExpression = "SELECT 1";
+ switch (parser) {
+ case "core":
+ config = SqlParser.config();
+ break;
+ case "babel":
+ config =
SqlParser.config().withParserFactory(SqlBabelParserImpl.FACTORY);
+ break;
+ default:
+ throw new RuntimeException("Unsupported parser: " + parser);
+ }
+ }
+
+ @Benchmark
+ public SqlParser instantiateParser() {
+ return call(stackDepth);
+ }
+
+ // used to increase the stack depth
+ private SqlParser call(final int depth) {
+ if (depth == 0) {
+ return SqlParser.create(sqlExpression, config);
+ }
+ return call(depth - 1);
+ }
+
+ public static void main(String[] args) throws RunnerException {
+ Options opt = new
OptionsBuilder().include(ParserInstantiationBenchmark.class.getSimpleName())
+ .detectJvmArgs()
+ .build();
+
+ new Runner(opt).run();
+ }
+}
