caicancai commented on PR #3864: URL: https://github.com/apache/calcite/pull/3864#issuecomment-2238396447
> > Maybe the result of the cli cannot be changed to be effective, but it is indeed improved a little from the code point of view > > I am not sure I get your point, sonar is failing with OOM sometimes, the idea is to increase memory a bit and try enough runs to see if it stops failing with the new proposed values. > > Determining how many runs are enough is a bit tricky, but from observing the frequency of failures, I guess 20 are enough. > > I have seen it failing for commits with little or no changes in the past, so my assumption is that empty commits would trigger a failure too if repeated enough times with an insufficient value, but that's hard to prove. Based on my recent experience with calcite, I guess that the triggering of OOM is that one PR or several PRs are submitted frequently in a period of time, which will cause OOM to occur. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
