caicancai commented on PR #3865: URL: https://github.com/apache/calcite/pull/3865#issuecomment-2238796456
> @normanj-bitquill overall LGTM. I think that current patch is wider than the original intent, so perhaps we should adjust the Jira title (and commit message) to something broader, e.g. "Add LEN and LENGTH functions to missing libraries", wdyt? @rubenada Thank you for your reply. I am worried that in some negative tests, the results of each dialect may be different. Do you mind if I test it on some databases first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
