NobiGo commented on code in PR #3873:
URL: https://github.com/apache/calcite/pull/3873#discussion_r1685363908
##########
core/src/test/java/org/apache/calcite/test/TypeCoercionTest.java:
##########
@@ -105,21 +105,21 @@ private static ImmutableList<RelDataType> combine(
final Fixture f = fixture();
f.checkCommonType(f.nullType, f.nullType, f.nullType, true);
// BOOLEAN
- f.checkCommonType(f.nullType, f.booleanType, f.booleanType, true);
+ f.checkCommonType(f.nullType, f.booleanType, f.nullableBooleanType, true);
Review Comment:
@caicancai Please check this test. Before this PR, we thought NULL and
Boolean's common type was Boolean. After this PR. The common types will be
nullableBoolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
