caicancai commented on code in PR #3877: URL: https://github.com/apache/calcite/pull/3877#discussion_r1685861138
########## site/_docs/reference.md: ########## @@ -1395,7 +1395,7 @@ Not implemented: | OCTET_LENGTH(binary) | Returns the number of bytes in *binary* | POSITION(binary1 IN binary2) | Returns the position of the first occurrence of *binary1* in *binary2* | POSITION(binary1 IN binary2 FROM integer) | Returns the position of the first occurrence of *binary1* in *binary2* starting at a given point (not standard SQL) -| OVERLAY(binary1 PLACING binary2 FROM integer [ FOR integer2 ]) | Replaces a substring of *binary1* with *binary2* +| OVERLAY(binary1 PLACING binary2 FROM integer [ FOR integer2 ]) | Replaces a substring of *string1* with *string2*, starting at the specified position *integer* in *string1* and optionally for a specified length *integer2* Review Comment: `OVERLAY(binary1 PLACING binary2 FROM integer [ FOR integer2 ])` Did you notice the parameter list? The parameter names here need to correspond to the parameters in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
