mihaibudiu commented on code in PR #3875:
URL: https://github.com/apache/calcite/pull/3875#discussion_r1686976230
##########
arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowData.java:
##########
@@ -89,6 +96,26 @@ private Schema makeArrowSchema() {
return new Schema(childrenBuilder.build(), null);
}
+ private Schema makeArrowTypeMetaDataSchema() {
+ ImmutableList.Builder<Field> childrenBuilder = ImmutableList.builder();
+ FieldType tinyIntType = FieldType.nullable(new ArrowType.Int(8, true));
+ FieldType smallIntType = FieldType.nullable(new ArrowType.Int(16, true));
+ FieldType intType = FieldType.nullable(new ArrowType.Int(32, true));
+ FieldType stringType = FieldType.nullable(new ArrowType.Utf8());
+ FieldType floatType =
Review Comment:
does arrow support both double and single precision for doubles?
Then I would do both at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]