asolimando commented on PR #3881: URL: https://github.com/apache/calcite/pull/3881#issuecomment-2247457792
> > I'm working on the `LIKE` operator for Elasticsearch and noticed that the `ElasticSearchAdapterTests` are not using a helper method setting up a connection to Elasticsearch consistently, but rather duplicate code sometimes. I want to keep the change separate to not clutter the diff in the `LIKE` operator PR. > > I think this change can create a jira case to illustrate it. > > I see no need to create jira case mainly just fixing some typos and adding some simple tests Agreed, please create a Jira ticket @timgrein, direct PRs are for really minor fixes like typos etc., this one it's worth a ticket IMO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
