asolimando commented on PR #3864: URL: https://github.com/apache/calcite/pull/3864#issuecomment-2255857489
> Hey @asolimando , I have seen ([5165fab](https://github.com/apache/calcite/commit/5165fab9438c073fef26e699f58a0ed8c8474325)) that you are trying to change the heap size only for Sonar but I don't think its necessary. The 0.5g increase is very modest and I feel that it will be a positive thing overall. My previous comment was just for clarity not for requesting changes. Thanks @zabetak for the clarification, I wanted to check if it was feasible (and it is, I had it working on a commit and broke it while testing other stuff). I agree that we can just increase of 0.5g and being done with it, it was informative to see that it's possible to just increase the sonar job separately in CI, in case we will need it in the future. I will clean the code back to the state it had when you guys approved and force-push it before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
