caicancai commented on code in PR #3889:
URL: https://github.com/apache/calcite/pull/3889#discussion_r1695496437
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##########
@@ -258,7 +258,7 @@ protected boolean needToCast(SqlValidatorScope scope,
SqlNode node,
RelDataType fromType = validator.deriveType(scope, node);
// This depends on the fact that type validate happens before coercion.
// We do not have inferred type for some node, i.e. LOCALTIME.
Review Comment:
It seems that judging the type of node, null and SqlTypeName.NUL are not
equivalent in my opinion. Do we need to improve this part of the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
