NobiGo commented on code in PR #3892:
URL: https://github.com/apache/calcite/pull/3892#discussion_r1697800510
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3682,9 +3682,22 @@ static AbstractRexCallImplementor
of(AbstractRexCallImplementor implementor) {
@Override Expression implementSafe(final RexToLixTranslator translator,
final RexCall call, final List<Expression> argValueList) {
+ // E.g., "final Boolean resultValue = (callValue == null) ? null :
!callValue"
final Expression expression =
implementor.implementSafe(translator, call, argValueList);
- return Expressions.not(expression);
+ final ParameterExpression callValue =
Review Comment:
Yes, the NotImplementor can't handle when BuiltInMethod.IS_JSON_VALUE.method
return null. Before this PR. If BuiltInMethod.IS_JSON_VALUE.method return null
then NotImplementor will generate `!NULL`, this is invalid. After this PR,
NotImplementor will generate `jsonValue==null? null : !jsonValue`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
