dssysolyatin commented on code in PR #3896:
URL: https://github.com/apache/calcite/pull/3896#discussion_r1700792175
##########
mongodb/src/main/java/org/apache/calcite/adapter/mongodb/MongoRules.java:
##########
@@ -114,10 +114,14 @@ static String quote(String s) {
}
private static boolean needsQuote(String s) {
- for (int i = 0, n = s.length(); i < n; i++) {
+ if (!s.isEmpty()
Review Comment:
Probably the best option would be to find a specification for fieldName and
add it as a comment. I will try to find it tomorrow. Because usually, people
don't write tests to check if letters 'e', 'a', or 'b' are allowed in the
middle of a string if the specification states that they are allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
