mihaibudiu commented on code in PR #3883:
URL: https://github.com/apache/calcite/pull/3883#discussion_r1709964160
##########
core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java:
##########
@@ -786,6 +788,9 @@ public TrimResult trimFields(
+ join.getLeft().getRowType().getFieldCount()
+ join.getRight().getRowType().getFieldCount();
final RexNode conditionExpr = join.getCondition();
+ final RexNode matchConditionExpr = (join instanceof LogicalAsofJoin)
+ ? ((LogicalAsofJoin) join).getMatchCondition()
Review Comment:
Do you suggest an Objects.requireNonNull? I am not sure what you would gain
from that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
