NobiGo commented on code in PR #3917:
URL: https://github.com/apache/calcite/pull/3917#discussion_r1722464357
##########
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeSystemImpl.java:
##########
@@ -160,6 +162,10 @@ public abstract class RelDataTypeSystemImpl implements
RelDataTypeSystem {
return 19;
}
+ @Override public RoundingMode roundingMode() {
Review Comment:
Do you mean using the default RoundingMode? There are already APIs in
Calcite that use DOWN, so I set the default rounding is DOWN.
`Primitive#numberValue` uses the DOWN mode to convert the decimal、float and
double to long. WDYT？ And I check the `BigDecimal#intValue` uses the DOWN to
convert number to int. So the default RoundingMode is DOWN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
