NobiGo commented on PR #3917: URL: https://github.com/apache/calcite/pull/3917#issuecomment-2300024154
> There may be other places where rounding happens silently, but I guess we won't discover these easily. (For example I think BigDecimal.longValue does rounding silently). One way to discover them would be to write a lot of tests that cast every type possible to every type possible that requires rounding, using multiple values around the corner cases. But that could be left for a separate PR. @mihaibudiu Yes. I know. Many places still use default APIs, which are not completely consistent with this configuration. We are currently unable to assess the boundaries of this issue. Once we discover the problem, we will submit a new PR to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
