julianhyde commented on code in PR #3927:
URL: https://github.com/apache/calcite/pull/3927#discussion_r1727706859
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -15523,6 +15523,58 @@ void checkBitAnd(SqlOperatorFixture f0, FunctionAlias
functionAlias) {
f0.forEachLibrary(list(functionAlias.libraries), consumer);
}
+ @Test public void testBitCountFunc() {
Review Comment:
add javadoc. explain that one tests BITCOUNT and the other tests BIT_COUNT.
are these methods identical? do you intend them to stay identical? If so,
share code, don't copy-paste. We have done that for other operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
