normanj-bitquill commented on code in PR #3927:
URL: https://github.com/apache/calcite/pull/3927#discussion_r1731788331
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -15523,6 +15523,64 @@ void checkBitAnd(SqlOperatorFixture f0, FunctionAlias
functionAlias) {
f0.forEachLibrary(list(functionAlias.libraries), consumer);
}
+ @Test void testBitCountFunc() {
+ checkBitCount(SqlStdOperatorTable.BITCOUNT, null, false);
+ }
+
+ @Test void testBitCountMySQLFunc() {
+ checkBitCount(SqlLibraryOperators.BIT_COUNT_MYSQL, list(SqlLibrary.MYSQL),
true);
+ }
+
+ void checkBitCount(SqlFunction function, @Nullable List<SqlLibrary>
libraries,
+ boolean testDecimal) {
+ final SqlOperatorFixture f0 = fixture();
+ f0.setFor(function, VmName.EXPAND);
+ final String functionName = function.getName();
+ final Consumer<SqlOperatorFixture> consumer = f -> {
+ f.checkFails(functionName + "(^*^)", "Unknown identifier '\\*'", false);
+ f.checkType(functionName + "(1)", "BIGINT NOT NULL");
+ f.checkType(functionName + "(CAST(2 AS TINYINT))", "BIGINT NOT NULL");
+ f.checkType(functionName + "(CAST(2 AS SMALLINT))", "BIGINT NOT NULL");
+ f.checkFails(
+ "^" + functionName + "()^",
+ "Invalid number of arguments to function '" + functionName
+ + "'. Was expecting 1 arguments",
+ false);
+ f.checkFails(
+ "^" + functionName + "(1, 2)^",
+ "Invalid number of arguments to function '" + functionName
+ + "'. Was expecting 1 arguments",
+ false);
+ f.checkScalar(functionName + "(8)", "1", "BIGINT NOT NULL");
+ f.checkScalar(functionName + "(CAST(x'ad' AS BINARY(1)))", "5", "BIGINT
NOT NULL");
+ f.checkScalar(functionName + "(-1)", "64", "BIGINT NOT NULL");
+ f.checkNull(functionName + "(cast(NULL as TINYINT))");
Review Comment:
Added a test for `NULL` without a cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
