ChengJie1053 commented on PR #3930:
URL: https://github.com/apache/calcite/pull/3930#issuecomment-2311597254

   > Ideally you should avoid code duplication, especially when the 
control-flow is so complicated. In this case you should probably create a 
static method that takes a double and returns a string, and call it from both 
places.
   
   Ok, thank you for helping me review the code, I will modify this place
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to