NobiGo commented on code in PR #3934:
URL: https://github.com/apache/calcite/pull/3934#discussion_r1739556992
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -4292,18 +4294,27 @@ private static List<Expression> args(RexCall call,
operand0 = operands.left;
operand1 = operands.right;
boolean nonPositiveIsNull = library == SqlLibrary.MYSQL ? true : false;
Review Comment:
Maybe we should refactor the code in another issue. The current code here
has poor extensibilit.
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -4292,18 +4294,27 @@ private static List<Expression> args(RexCall call,
operand0 = operands.left;
operand1 = operands.right;
boolean nonPositiveIsNull = library == SqlLibrary.MYSQL ? true : false;
Review Comment:
We should pass the library as the Parameter. Then the code logic will be
clear. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
