NobiGo commented on code in PR #3944:
URL: https://github.com/apache/calcite/pull/3944#discussion_r1741320989
##########
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeSystemImpl.java:
##########
@@ -57,7 +57,7 @@ public abstract class RelDataTypeSystemImpl implements
RelDataTypeSystem {
case INTERVAL_SECOND:
return SqlTypeName.MAX_INTERVAL_FRACTIONAL_SECOND_PRECISION;
default:
- return -1;
+ return RelDataType.PRECISION_NOT_SPECIFIED;
Review Comment:
SCALE_NOT_SPECIFIED ?
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -3684,12 +3684,15 @@ private SqlDialect nonOrdinalDialect() {
String query = "select cast(\"product_id\" as char) from \"product\"";
final String expectedMysql = "SELECT CAST(`product_id` AS CHAR)\n"
+ "FROM `foodmart`.`product`";
+ final String expectedMssql = "SELECT CAST([product_id] AS CHAR)\n"
Review Comment:
Add test about if Char with precision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
