julianhyde commented on PR #3939:
URL: https://github.com/apache/calcite/pull/3939#issuecomment-2327255542
@mihaibudiu
> Would you like some of this code reviewed?
I see @NobiGo has reviewed and approved. I think we're good.
The vast majority of changes don't require review - there was only one
choice to make. In one or two places I had to make a decision; e.g. in
MongoEnumerator I added the 3 `if` ... `throw` lines, because the alternative,
to change the return to `@Nullable Object`, was inferior:
```
@Override public Object current() {
if (current == null) {
throw new IllegalStateException();
}
return current;
}
```
> This may cause lots of conflicts if people have work under way.
Agreed. I will minimize conflicts by merging this quickly, and avoiding
changes that require discretion. I will probably merge today.
@NobiGo, Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
