julianhyde commented on PR #3946: URL: https://github.com/apache/calcite/pull/3946#issuecomment-2329643745
This PR feels too small. In calcite, a commit that is merged to main is generally at the grain of a jira case, and a jira case is a bug or a feature. Commits merged to main are rarely small tasks. (For small tasks such as fixing typos, we recommend PRs without a jira case.) I see that CALCITE-6561, the identifier of this PR, is logged as a bug, so that's a good start. I'd start a dev branch with 6561 in its name, use the bug description as the PR summary, and add 'Add test case for [CALCITE-6561] Measure query gives incorrect result when GROUP BY key is NULL' as the first commit. You can note in the commit message that there are commented-out test cases for other bugs. When the bug is fixed, all the commits on the branch will be squash-merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
