julianhyde commented on code in PR #3960:
URL: https://github.com/apache/calcite/pull/3960#discussion_r1759413700
##########
core/src/test/java/org/apache/calcite/test/LintTest.java:
##########
@@ -393,6 +395,27 @@ private static void checkMessage(String subject, String
body,
if (subject2.matches("[a-z].*")) {
consumer.accept("Message must start with upper-case letter");
}
+
+ // Check for keywords that should be capitalized
Review Comment:
Consider moving keywordMap, and its population, outside the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
