mihaibudiu commented on code in PR #2811:
URL: https://github.com/apache/calcite/pull/2811#discussion_r1760396371
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##########
@@ -91,11 +91,21 @@ public abstract class AbstractTypeCoercion implements
TypeCoercion {
* Cast operand at index {@code index} to target type.
* we do this base on the fact that validate happens before type coercion.
*/
+
protected boolean coerceOperandType(
@Nullable SqlValidatorScope scope,
SqlCall call,
int index,
RelDataType targetType) {
+ return coerceOperandType(scope, call, index, targetType, true);
+ }
+
+ protected boolean coerceOperandType(
+ @Nullable SqlValidatorScope scope,
+ SqlCall call,
+ int index,
+ RelDataType targetType,
+ boolean isUpdateValidate) {
Review Comment:
I would name this parameter "updateValidator"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
