julianhyde commented on PR #3965:
URL: https://github.com/apache/calcite/pull/3965#issuecomment-2356629294
Looks pretty good.
I'm tempted to make the following next steps:
* Rework it to make SqlValidator implement ScopeMap, and reduce the amount
of noise. (I take your point that maybe the interfaces should be decoupled
eventually.)
* Make ScopeMapImpl package-private
* Make ScopeMapImpl it immutable (with the mutable bits in a builder)
* Address the Checkerframework issues (yes they are painful, but they
generally point to real problems in lifecycle)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
