caicancai commented on PR #3966: URL: https://github.com/apache/calcite/pull/3966#issuecomment-2357399599
> @mihaibudiu, @caicancai, we found one issue with this patch that needs attention. After this fix, SCALAR_QUERY is present in sourceExpressionList of original `SqlUpdate` AST node. The `SqlToRelConverter` test uses the deprecated `withExpand(false)` config setting, and as a result, SCALAR_QUERY is replaced to a constant. And that's ok, but when using `withExpand(true)` this SCALAR_QUERY will not be replaced with a constant even at planning phase (may be the problem in `SubQueryRemoveRule` or somewhere else). As a result, we can observe in the "physical" plan the original SCALAR_SUBQUERY (with LOGICAL nodes) in the `sourceExpressionList` of `TableModify` 🤔 > > If the patch needs to be improved, then feel free to remove it from the current scope (1.38.0), so that it doesn't delay the release. You mean that it can only be recognized as a constant in the physical stage? It feels strange. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
