mihaibudiu commented on code in PR #2811:
URL: https://github.com/apache/calcite/pull/2811#discussion_r1772444313
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -1958,7 +1959,33 @@ private RelOptUtil.Exists convertExists(
if (!values.getTuples().isEmpty()) {
unionInputs.add(values);
}
- resultRel = LogicalUnion.create(unionInputs, true);
+ RelDataType finalRowType = rowType;
Review Comment:
Great, so you deleted code which was omitting the casts.
The question I have: is this change handling correctly a query with union?
Or is the change in the SqlToRelConverter still required to make the test
pass? If it's still required, it means that there is somewhere another bug.
If it's not required, perhaps you don't need to add this change about union
in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
