suibianwanwank opened a new pull request, #3976: URL: https://github.com/apache/calcite/pull/3976
This PR supports getPredicates(RelSubset) returning getPredicate(stripped) in place of EMPTY as a temporary solution. But it exceeds the expected range because some rules are re-fire in VolcanoPlanner. Major Changes: In SortRemoveConstantKey the constant key in the sort is removed. before this PR the traitset of the sort needs to be consistent with the collation. It would result in the new sort having a different traitset than the original one, it would not be in the same RelSubSet and would not be selected. So I tried to modify the traitSet assert in sort so that it can be set to RelComposetrait. For example : order by a,b,c If we can make sure that b is constant, then the traitSet of the sort can be [[a,b,c],[a,c]]. Also, when collation is empty and there are only offset and fetch, the original input collation traits can be kept in the sort. There are also a few more changes that I will add comments on. For the Sort changes, we can probably discuss them in Jira if needed. Thanks for the suggestion and review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
